Rename FBX2glTF binary path setting back to 4.2 name #92571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves compatibility when upgrading Godot 4.2 projects which relied on that path being configured in the editor settings. The old name also makes sense for this one, it's fine for fbx2gltf_path to be under a generic fbx category which could have more settings also impacting ufbx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves compatibility when upgrading Godot 4.2 projects which relied on that path being configured in the editor settings.
The old name also makes sense for this one, it's fine for fbx2gltf_path to be under a generic fbx category which could have more settings also impacting ufbx. I was the one doing this rename as part of cleaning up #81746, my bad.
I didn't change the project setting
filesystem/import/fbx2gltf/enabledback tofbx/enabledbecause this one would really be confusing. But it's also enabled by default in 4.2, so this won't change anything for users who do use fbx2gltf. For those who turned it off, they'll experience either way that their fbx files are now imported by ufbx in 4.3.